Mirrors/yuzu
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
16906 commits 1 branch 0 tags 106 MiB
Commit graph

4914 commits

Author SHA1 Message Date
bunnei
94eca09cf6 video_core: cdma_pusher: Add missing LOG_DEBUG field in ExecuteCommand. 2020-10-28 16:47:08 -07:00
ReinUsesLisp
657771bdcb shader: Partially implement texture cube array shadow 
This implements texture cube arrays with shadow comparisons but doesn't
fix the asserts related to it.

Fixes out of bounds reads on swizzle constructors and makes them use
bounds checked ::at instead of the unsafe operator[].
 2020-10-28 17:12:40 -03:00
ReinUsesLisp
44b552be71 shader/arithmetic: Implement FCMP immediate + register variant 
Trivially add the encoding for this.
 2020-10-28 17:05:41 -03:00
LC
978e7897a3
Merge pull request #4848 from ReinUsesLisp/type-limits 
video_core: Enforce -Werror=type-limits
 2020-10-28 03:16:10 -04:00
ReinUsesLisp
79da90cea8 video_core: Enforce -Wredundant-move and -Wpessimizing-move 
Silence three warnings and make them errors to avoid introducing more in the future.
 2020-10-28 02:44:50 -03:00
ReinUsesLisp
4a451e5849 video_core: Enforce -Werror=type-limits 
Silences one warning and avoids introducing more in the future.
 2020-10-28 02:37:47 -03:00
Lioncash
047e77e2f0 sync_manager: Amend parameter order of calls to SyncptIncr constructor 
Corrects some cases where the arguments would be incorrectly swapped.
 2020-10-27 03:22:57 -04:00
Lioncash
cce14b4cd7 h264: Make WriteUe take a u32 
Enforces the type of the desired value in calling code.
 2020-10-27 03:21:53 -04:00
Lioncash
6291975731 vp9: std::move buffer within ComposeFrameHeader() 
We can move the buffer here to avoid a heap reallocation
 2020-10-27 02:27:31 -04:00
Lioncash
00decfbb07 vp9: Remove dead code 2020-10-27 02:26:17 -04:00
Lioncash
111802bbbb vp9: Join declarations with assignments 2020-10-27 02:26:03 -04:00
Lioncash
3b5d5fa86f vp9: Remove pessimizing moves 
The move will already occur without std::move.
 2020-10-27 02:21:40 -04:00
Lioncash
dcc26c54a5 vp9: Resolve variable shadowing 2020-10-27 02:20:17 -04:00
Lioncash
c04203b786 nvdec: Tidy up header includes 
Prevents a few unnecessary inclusions.
 2020-10-27 02:16:42 -04:00
ameerj
eb67a45ca8 video_core: NVDEC Implementation 
This commit aims to implement the NVDEC (Nvidia Decoder) functionality, with video frame decoding being handled by the FFmpeg library.

The process begins with Ioctl commands being sent to the NVDEC and VIC (Video Image Composer) emulated devices. These allocate the necessary GPU buffers for the frame data, along with providing information on the incoming video data. A Submit command then signals the GPU to process and decode the frame data.

To decode the frame, the respective codec's header must be manually composed from the information provided by NVDEC, then sent with the raw frame data to the ffmpeg library.

Currently, H264 and VP9 are supported, with VP9 having some minor artifacting issues related mainly to the reference frame composition in its uncompressed header.

Async GPU is not properly implemented at the moment.

Co-Authored-By: David <25727384+ogniK5377@users.noreply.github.com>
 2020-10-26 23:07:36 -04:00
bunnei
3e46934442
Merge pull request #4706 from ReinUsesLisp/cmake-host-shaders 
video_core: Fix instances where msbuild always regenerated host shaders
 2020-10-23 10:01:16 -07:00
Lioncash
678d012c2c video_core: Conditially activate relevant compiler warnings 
These compiler flags aren't shared with clang, so specifying these flags
unconditionally can lead to a bit of warning spam.

While we're in the area, we can also enable -Wunused-but-set-parameter
given this is almost always a bug.
 2020-10-20 20:28:25 -04:00
ReinUsesLisp
f21a189148 gl_arb_decompiler: Implement robust buffer operations 
This emulates the behavior we get on GLSL with regular SSBOs with a
pointer + length pair. It aims to be consistent with the crashes we
might get.

Out of bounds stores are ignored. Atomics are ignored and return zero.
Reads return zero.
 2020-10-20 03:34:32 -03:00
bunnei
f1ead11df7
Merge pull request #4204 from ReinUsesLisp/vulkan-1.0 
renderer_vulkan: Create and properly use Vulkan 1.0 instances when 1.1 is not available
 2020-10-19 14:18:54 -07:00
bunnei
743fe1aea3
Merge pull request #4782 from ReinUsesLisp/remove-dyn-primitive 
vk_graphics_pipeline: Manage primitive topology as fixed state
 2020-10-17 22:14:17 -07:00
bunnei
d47ac3ce09
Merge pull request #4772 from goldenx86/block-rdna 
vk_device: Block VK_EXT_extended_dynamic_state for RDNA devices
 2020-10-14 17:51:39 -07:00
ReinUsesLisp
e4e0abc418 vk_graphics_pipeline: Manage primitive topology as fixed state 
Vulkan has requirements for primitive topologies that don't play nicely
with yuzu's. Since it's only 4 bits, we can move it to fixed state
without changing the size of the pipeline key.

- Fixes a regression on recent Nvidia drivers on Fire Emblem: Three
  Houses.
 2020-10-13 04:08:33 -03:00
bunnei
4c348f4069
Merge pull request #4766 from ReinUsesLisp/tmml-cube 
shader/texture: Implement CUBE texture type for TMML and fix arrays
 2020-10-12 12:53:57 -07:00
ReinUsesLisp
e1600b0962 video_core: Enforce -Wclass-memaccess 2020-10-09 16:46:11 -03:00
LC
61b246a3a9
Merge pull request #4771 from ReinUsesLisp/warn-unused-var 
video_core: Enforce -Wunused-variable and -Wunused-but-set-variable
 2020-10-08 21:10:31 -04:00
goldenx86
0120e5b1d9 vk_device: Block VK_EXT_extended_dynamic_state for RDNA devices 
RDNA devices seem to crash when using VK_EXT_extended_dynamic_state in
the latest 20.9.2 proprietary Windows drivers. As a workaround, for now
we block device names corresponding to current RDNA released products.
 2020-10-08 21:27:49 -03:00
ReinUsesLisp
dffaffaac1 shader/texture: Implement CUBE texture type for TMML and fix arrays 
TMML takes an array argument that has no known meaning, this one appears
as the first component in gpr8 followed by s, t and r. Skip this
component when arrays are being used. Also implement CUBE texture types.

- Used by Pikmin 3: Deluxe Demo.
 2020-10-07 23:17:46 -03:00
ReinUsesLisp
cd3e959f23 renderer_vulkan/wrapper: Fix physical device sorting 
The old code had a sort function that was invalid and it didn't work as
expected when the base vector had a different order (e.g. renderdoc was
attached).

This sorts devices as expected and fixes a debug assert on MSVC.
 2020-10-07 17:13:22 -03:00
ReinUsesLisp
2a24b1c973 video_core: Enforce -Wunused-variable and -Wunused-but-set-variable 2020-10-02 21:19:35 -03:00
Matías Locatti
d7843b8ef2
Remove ext_extended_dynamic_state blacklist 
Latest AMD 20.9.2 driver fixed this, there's no reason to keep it blocked, as the previous stable signed driver release doesn't include the extension.
 2020-09-30 03:13:38 -03:00
Rodrigo Locatti
e5a1e0a76d
Merge pull request #4724 from lat9nq/fix-vulkan-nvidia-allocate-2 
vk_stream_buffer: Fix initializing Vulkan with NVIDIA on Linux
 2020-09-26 23:52:49 +00:00
bunnei
442096298e
Merge pull request #4703 from lioncash/desig7 
shader/registry: Make use of designated initializers where applicable
 2020-09-26 15:23:15 -07:00
lat9nq
ca26fd0f42 vk_stream_buffer: Fix initializing Vulkan with NVIDIA on Linux 
The previous fix only partially solved the issue, as only certain GPUs that needed 9 or less MiB subtracted would work (i.e. GTX 980 Ti, GT 730). This takes from DXVK's example to divide `heap_size` by 2 to determine `allocable_size`. Additionally tested on my Quadro K4200, which previously required setting it to 12 to boot.
 2020-09-25 17:42:59 -04:00
Lioncash
940d85241b vk_command_pool: Move definition of Pool into the cpp file 
Allows the implementation details to be changed without recompiling any
files that include this header.
 2020-09-25 00:15:52 -04:00
Lioncash
4ed4bba305 vk_command_pool: Make use of override on destructor 2020-09-25 00:14:10 -04:00
Lioncash
e0f2db4376 vk_command_pool: Add missing header guard 2020-09-25 00:12:45 -04:00
bunnei
2634e3c6eb
Merge pull request #4711 from lioncash/move5 
arithmetic_integer_immediate: Make use of std::move where applicable
 2020-09-24 21:02:42 -07:00
Lioncash
e3a615a616 arithmetic_integer_immediate: Make use of std::move where applicable 
Same behavior, minus any redundant atomic reference count increments and
decrements.
 2020-09-24 13:28:45 -04:00
ReinUsesLisp
67af0323f0 video_core: Fix instances where msbuild always regenerated host shaders 
When HEADER_GENERATOR was included in the DEPENDS section of custom
commands, msbuild assumed this was always modified. Changing this file
is not common so we can remove it from there.
 2020-09-23 22:27:17 -03:00
bunnei
d66b897a6d
Merge pull request #4674 from ReinUsesLisp/timeline-semaphores 
renderer_vulkan: Make unconditional use of VK_KHR_timeline_semaphore
 2020-09-23 18:24:27 -07:00
Lioncash
77532ebde3 shader/registry: Silence a -Wshadow warning 2020-09-23 15:10:25 -04:00
Lioncash
cd6f4f7eed shader/registry: Remove unnecessary namespace qualifiers 
Using statements already make these unnecessary.
 2020-09-23 15:08:34 -04:00
Lioncash
ffeb4ef83e shader/registry: Make use of designated initializers where applicable 
Same behavior, less repetition.
 2020-09-23 15:06:25 -04:00
Lioncash
0dc6967ff1 control_flow: emplace elements in place within TryQuery() 
Places data structures where they'll eventually be moved to to avoid
needing to even move them in the first place.
 2020-09-22 22:54:36 -04:00
Lioncash
fcd0145eb5 control_flow: Make use of std::move in InsertBranch() 
Avoids unnecessary atomic increments and decrements.
 2020-09-22 22:48:09 -04:00
Lioncash
ff45c39578 General: Make use of std::nullopt where applicable 
Allows some implementations to avoid completely zeroing out the internal
buffer of the optional, and instead only set the validity byte within
the structure.

This also makes it consistent how we return empty optionals.
 2020-09-22 17:32:33 -04:00
ReinUsesLisp
7003090187 renderer_opengl: Remove emulated mailbox presentation 
Emulated mailbox presentation was causing performance issues on
Nvidia's OpenGL driver. Remove it.
 2020-09-20 16:29:41 -03:00
ReinUsesLisp
4f5bbe56ba vk_query_cache: Hack counter destructor to avoid reserving queries 
This is a hack to destroy all HostCounter instances before the base
class destructor is called. The query cache should be redesigned to have
a proper ownership model instead of using shared pointers.

For now, destroy the host counter hierarchy from the derived class
destructor.
 2020-09-19 01:47:29 -03:00
ReinUsesLisp
58b0ae84b5 renderer_vulkan: Make unconditional use of VK_KHR_timeline_semaphore 
This reworks how host<->device synchronization works on the Vulkan
backend. Instead of "protecting" resources with a fence and signalling
these as free when the fence is known to be signalled by the host GPU,
use timeline semaphores.

Vulkan timeline semaphores allow use to work on a subset of D3D12
fences. As far as we are concerned, timeline semaphores are a value set
by the host or the device that can be waited by either of them.

Taking advantange of this, we can have a monolithically increasing
atomic value for each submission to the graphics queue. Instead of
protecting resources with a fence, we simply store the current logical
tick (the atomic value stored in CPU memory). When we want to know if a
resource is free, it can be compared to the current GPU tick.

This greatly simplifies resource management code and the free status of
resources should have less false negatives.

To workaround bugs in validation layers, when these are attached there's
a thread waiting for timeline semaphores.
 2020-09-19 01:46:37 -03:00
Lioncash
91bca9eb0b fermi_2d: Make use of designated initializers 
Same behavior, less repetition. We can also ensure all members of Config
are initialized.
 2020-09-18 13:55:21 -04:00
Rodrigo Locatti
31461589c5
Merge pull request #4672 from lioncash/narrowing 
decoder/texture: Eliminate narrowing conversion in GetTldCode()
 2020-09-17 21:17:54 +00:00
Lioncash
4944d48ee8 decode/image: Eliminate switch fallthrough in DecodeImage() 
Fortunately this didn't result in any issues, given the block that code
was falling through to would immediately break.
 2020-09-17 15:12:18 -04:00
Lioncash
ffc66f089d decoder/texture: Eliminate narrowing conversion in GetTldCode() 
The assignment was previously truncating a u64 value to a bool.
 2020-09-17 15:04:17 -04:00
ReinUsesLisp
eb914b6c50 video_core: Enforce -Werror=switch 
This forces us to fix all -Wswitch warnings in video_core.
 2020-09-16 17:48:01 -03:00
ReinUsesLisp
9e87193725 video_core: Remove all Core::System references in renderer 
Now that the GPU is initialized when video backends are initialized,
it's no longer needed to query components once the game is running: it
can be done when yuzu is booting.

This allows us to pass components between constructors and in the
process remove all Core::System references in the video backend.
 2020-09-06 05:28:48 -03:00
bunnei
94a25b75a0
Merge pull request #4611 from lioncash/xbyak2 
externals: Update Xbyak to 5.96
 2020-09-03 20:24:27 -04:00
bunnei
39319f09d8
Merge pull request #4575 from lioncash/async 
async_shaders: Mark getters as const member functions
 2020-09-03 11:34:30 -04:00
ReinUsesLisp
c573920c01 vk_device: Fix driver id check on AMD for VK_EXT_extended_dynamic_state 
'driver_id' can only be known on Vulkan 1.1 after creating a logical
device. Move the driver id check to disable
VK_EXT_extended_dynamic_state after the logical device is successfully
initialized.

The Vulkan device will have the extension enabled but it will not be
used.
 2020-08-30 20:22:48 -03:00
Lioncash
a5dcccfdd2 externals: Update Xbyak to 5.96 
I made a request on the Xbyak issue tracker to allow some constructors
to be constexpr in order to avoid static constructors from needing to
execute for some of our register constants.

This request was implemented, so this updates Xbyak so that we can make
use of it.
 2020-08-30 05:09:48 -04:00
ReinUsesLisp
fe90c4fd7b vk_device: Blacklist AMD proprietary from VK_EXT_extended_dynamic_state 
Vertex binding's <stride> is bugged on AMD's proprietary drivers when
using VK_EXT_extended_dynamic_state. Blacklist it for now while we
investigate how to report this issue to AMD.
 2020-08-28 19:14:57 -03:00
bunnei
9864da7d43
Merge pull request #4524 from lioncash/memory-log 
shader/memory: Amend UNIMPLEMENTED_IF_MSG without a message
 2020-08-27 00:16:10 -04:00
bunnei
1bb8c27a70
Merge pull request #4569 from ReinUsesLisp/glsl-cmake 
video_core/host_shaders: Add CMake integration for string shaders
 2020-08-26 22:57:39 -04:00
bunnei
1e2a92918b
Merge pull request #4555 from ReinUsesLisp/fix-primitive-topology 
vk_state_tracker: Fix primitive topology
 2020-08-26 22:19:52 -04:00
Lioncash
7b50c48df7 memory_manager: Make use of [[nodiscard]] in the interface 2020-08-26 20:15:03 -04:00
Lioncash
d12d59f62a memory_manager: Make operator+ const qualified 
This doesn't modify member state, so it can be marked as const.
 2020-08-26 20:11:58 -04:00
bunnei
902bf6d37d
Merge pull request #4574 from lioncash/const-fn 
memory_manager: Mark IsGranularRange() as a const member function
 2020-08-25 11:24:13 -04:00
bunnei
bb752df736
Merge pull request #4542 from ReinUsesLisp/gpu-init-base 
video_core: Initialize renderer with a GPU
 2020-08-24 22:56:11 -04:00
Lioncash
bafef3d1c9 async_shaders: Mark getters as const member functions 
While we're at it, we can also mark them as nodiscard.
 2020-08-24 01:15:50 -04:00
Lioncash
5bce81c3d6 memory_manager: Mark IsGranularRange() as a const member function 
This doesn't modify internal member state, so it can be marked as const.
 2020-08-24 00:37:57 -04:00
Lioncash
bae4e6c2f5 gl_texture_cache: Take std::string by reference in DecorateViewName() 
LabelGLObject takes a string_view, so we don't need to make copies of
the std::string.
 2020-08-23 23:36:33 -04:00
Lioncash
f3bb52c0a9 video_core/fence_manager: Remove unnecessary includes 
Avoids pulling in unnecessary things that can cause rebuilds when they
aren't required.
 2020-08-23 21:44:50 -04:00
ReinUsesLisp
91df2beee3 video_core/host_shaders: Add CMake integration for string shaders 
Add the necessary CMake code to copy the contents in a string source
shader (GLSL or GLASM) to a header file then consumed by video_core
files.

This allows editting GLSL in its own files without having to maintain
them in source files.

For now, only OpenGL presentation shaders are moved, but we can add
GLASM presentation shaders and static SPIR-V generation through
glslangValidator in the future.
 2020-08-23 21:37:20 -03:00
ReinUsesLisp
0eaf7e1daa gl_shader_util: Use std::string_view instead of star pointer 
This allows us passing any type of string and hinting the length of the
string to the OpenGL driver.
 2020-08-23 21:23:54 -03:00
ReinUsesLisp
da53bcee60 video_core: Initialize renderer with a GPU 
Add an extra step in GPU initialization to be able to initialize render
backends with a valid GPU instance.
 2020-08-22 01:51:45 -03:00
bunnei
baff9ffcac
Merge pull request #4521 from lioncash/optionalcache 
gl_shader_disk_cache: Make use of std::nullopt where applicable
 2020-08-21 23:56:55 -04:00
bunnei
53fbf8e206
Merge pull request #4523 from lioncash/self-assign 
macro-interpreter: Resolve -Wself-assign-field warning
 2020-08-21 18:25:53 -04:00
ReinUsesLisp
aed6011d7c vk_state_tracker: Fix primitive topology 
State track the current primitive topology with a regular comparison
instead of using dirty flags.

This fixes a bug in dirty flags for this particular state and it also
avoids unnecessary state changes as this property is stored in a
frequently changed bit field.
 2020-08-20 23:07:30 -03:00
ReinUsesLisp
c5a78f4480 vk_device: Use Vulkan 1.0 properly 
Enable the required capabilities to use Vulkan 1.0 without validation
errors and disable those that are not compatible with it.
 2020-08-20 16:55:22 -03:00
ReinUsesLisp
29a0ca2391 renderer_vulkan: Create a Vulkan 1.0 instance when 1.1 is not available 
This commit doesn't make yuzu compatible with Vulkan 1.0 yet, it only
creates an 1.0 instance.
 2020-08-20 16:55:22 -03:00
bunnei
3ea3de4ecd
Merge pull request #4546 from lioncash/telemetry 
common/telemetry: Migrate namespace into the Common namespace
 2020-08-20 14:29:13 -04:00
bunnei
2d2e235bcf
Merge pull request #4522 from lioncash/vulk-copy 
vulkan/wrapper: Avoid unnecessary copy in EnumerateInstanceExtensionProperties()
 2020-08-18 19:31:35 -04:00
Lioncash
f6bb905182 common/telemetry: Migrate namespace into the Common namespace 
Migrates the Telemetry namespace into the Common namespace to make the
code consistent with the rest of our common code.
 2020-08-18 15:08:32 -04:00
bunnei
56c6a5def8
Merge pull request #4535 from lioncash/fileutil 
common/fileutil: Convert namespace to Common::FS
 2020-08-17 22:35:30 -04:00
David
cbaf1bc711
Merge pull request #4443 from ameerj/vk-async-shaders 
vulkan_renderer: Async shader/graphics pipeline compilation
 2020-08-17 15:06:11 +10:00
David
a91acd5365
Merge pull request #4520 from lioncash/pessimize 
async_shaders: Resolve -Wpessimizing-move warning
 2020-08-17 14:36:05 +10:00
ameerj
fde8102a41 Remove unneeded newlines, optional Registry in shader params 
Addressing feedback from Rodrigo
 2020-08-16 16:33:21 -04:00
Ameer J
f49ffdd648 Morph: Update worker allocation comment 
Co-authored-by: Morph <39850852+Morph1984@users.noreply.github.com>
 2020-08-16 12:02:22 -04:00
ameerj
1b829fbd7a move thread 1/4 count computation into allocate workers method 2020-08-16 12:02:22 -04:00
ameerj
31a76410e8 Address feedback, add shader compile notifier, update setting text 2020-08-16 12:02:22 -04:00
ameerj
c02464f64e Vk Async Worker directly emplace in cache 2020-08-16 12:02:22 -04:00
ameerj
4539073ce1 Address feedback. Bruteforce delete duplicates 2020-08-16 12:02:22 -04:00
ameerj
6ac97405df Vk Async pipeline compilation 2020-08-16 12:02:22 -04:00
Lioncash
c4ed791164 common/fileutil: Convert namespace to Common::FS 
Migrates a remaining common file over to the Common namespace, making it
consistent with the rest of common files.

This also allows for high-traffic FS related code to alias the
filesystem function namespace as

namespace FS = Common::FS;

for more concise typing.
 2020-08-16 06:52:40 -04:00
bunnei
db96034ea4
Merge pull request #4528 from lioncash/discard 
common: Make use of [[nodiscard]] where applicable
 2020-08-16 01:47:54 -04:00
bunnei
404362e1b0
Merge pull request #4519 from lioncash/semi 
maxwell_3d: Resolve -Wextra-semi warning
 2020-08-16 00:55:15 -04:00
Lioncash
1ee060ca0d common/compression: Roll back std::span changes 
Seems like all compilers don't support std::span yet.
 2020-08-15 17:17:56 -04:00
bunnei
feb243b08d
Merge pull request #4416 from lioncash/span 
lz4_compression/zstd_compression: Make use of std::span in interfaces
 2020-08-15 00:53:11 -04:00
bunnei
2dace90346
Merge pull request #4453 from ReinUsesLisp/block-to-linear 
textures/decoders: Fix block linear to pitch copies
 2020-08-14 19:52:12 -04:00
Lioncash
dcc5562cd5 shader/memory: Amend UNIMPLEMENTED_IF_MSG without a message 
We need to provide a message for this variant of the macro, so we can
simply log out the type being used.
 2020-08-14 08:38:37 -04:00
Lioncash
34ec64233a macro-interpreter: Resolve -Wself-assign-field warning 
This was assigning the field to itself, which is a no-op. The size
doesn't change between its initial assignment and this one, so this is a
safe change to make.
 2020-08-14 08:26:50 -04:00
Lioncash
167d36ec3c vulkan/wrapper: Avoid unnecessary copy in EnumerateInstanceExtensionProperties() 
Given this is implicitly creating a std::optional, we can move the
vector into it.
 2020-08-14 08:23:49 -04:00
Lioncash
c8135b3c18 gl_shader_disk_cache: Make use of std::nullopt where applicable 
Allows the compiler to avoid unnecessarily zeroing out the internal
buffer of std::optional on some implementations.
 2020-08-14 08:20:44 -04:00
Lioncash
6b13d08822 async_shaders: Resolve -Wpessimizing-move warning 
Prevents pessimization of the move constructor (which thankfully didn't
actually happen in practice here, given std::thread isn't copyable).
 2020-08-14 08:16:50 -04:00
Lioncash
83d8bf9af9 maxwell_3d: Resolve -Wextra-semi warning 
Semicolons after a function definition aren't necessary.
 2020-08-14 08:13:41 -04:00
bunnei
a9de967fa3
Merge pull request #4514 from Morph1984/worker-alloc 
gl_shader_cache: Use std::max() for determining num_workers
 2020-08-13 17:06:57 -04:00
Lioncash
b724a4d90c General: Tidy up clang-format warnings part 2 2020-08-13 14:19:08 -04:00
Morph
e0ff98dd34 gl_shader_cache: Use std::max() for determining num_workers 
Does not allocate more threads than available in the host system for boot-time shader compilation and always allocates at least 1 thread if hardware_concurrency() returns 0.
 2020-08-12 09:23:34 -04:00
ReinUsesLisp
f00641459e textures/decoders: Fix block linear to pitch copies 
There were two issues with block linear copies. First the swizzling was
wrong and this commit reimplements them.

The other issue was that these copies are generally used to download
render targets from the GPU and yuzu was not downloading them from
host GPU memory unless the extreme GPU accuracy setting was selected.
This commit enables cached memory reads for all accuracy levels.

- Fixes level thumbnails in Super Mario Maker 2.
 2020-08-10 20:45:03 -03:00
bunnei
5429ea0e69
Merge pull request #4389 from ogniK5377/redundant-format-type 
video_core: Remove redundant pixel format type
 2020-08-07 09:33:58 -04:00
bunnei
f11628b9b7
Merge pull request #4430 from bunnei/new-gpu-vmm 
hle: nvdrv: Rewrite of GPU memory management.
 2020-08-04 18:44:26 -04:00
bunnei
efd1b57d03
Merge pull request #4445 from Morph1984/async-threads 
renderer_opengl: Use 1/4 of all threads for async shader compilation
 2020-08-04 18:43:42 -04:00
bunnei
0ae267bf77
Merge pull request #4469 from lioncash/missing 
vk_texture_cache: Silence -Wmissing-field-initializer warnings
 2020-08-04 06:59:51 -07:00
Lioncash
06809ad7bc vulkan: Silence more -Wmissing-field-initializer warnings 2020-08-03 12:28:57 -04:00
Lioncash
b249e4e0ce yuzu: Resolve C++20 deprecation warnings related to lambda captures 
C++20 deprecates capturing the this pointer via the '=' capture.
Instead, we replace it or extend the capture specification.
 2020-08-03 11:54:04 -04:00
David
0c262f8ac2
Merge pull request #4392 from lioncash/guard 
compatible_formats: Add missing header guard
 2020-07-31 01:08:56 +10:00
bunnei
4c0f6f1bc8
Merge pull request #4396 from lioncash/comma 
surface_params: Replace questionable usages of the comma operator with semicolons
 2020-07-29 19:55:44 -04:00
Morph
e8f22730d1 renderer_opengl: Use 1/4 of all threads for async shader compilation 2020-07-28 05:08:27 -04:00
bunnei
6b35317ff3
Merge pull request #4419 from lioncash/initializer 
vulkan: Resolve -Wmissing-field-initializer warnings
 2020-07-27 15:52:03 -07:00
Billy Laws
f490b4545d
video_core/gpu: Correct the size of the puller registers 
The puller register array is made up of u32s however the `NUM_REGS` value is the size in bytes, so switch it to avoid making the struct unnecessary large. Also fix a small typo in a comment.
 2020-07-26 22:26:29 +01:00
bunnei
05def61398 hle: nvdrv: Rewrite of GPU memory management. 2020-07-26 00:49:43 -04:00
Lioncash
80eedff9e1 vulkan: Resolve -Wmissing-field-initializer warnings 2020-07-25 03:50:18 -04:00
Lioncash
c5bdccfecb zstd_compression: Make use of std::span in interfaces 
Allows condensing the data and size parameters into a single argument.
 2020-07-25 03:11:56 -04:00
bunnei
dc2d31b1b2
Merge pull request #4393 from lioncash/unused5 
vk_rasterizer: Remove unused variable in Clear()
 2020-07-24 20:33:58 -07:00
bunnei
d488cb843e
Merge pull request #4388 from lioncash/written 
buffer_cache: Eliminate redundant map lookup in MarkRegionAsWritten()
 2020-07-24 11:29:37 -07:00
bunnei
f650cf8a9a
Merge pull request #4391 from lioncash/nrvo 
video_core: Allow copy elision to take place where applicable
 2020-07-24 06:33:09 -07:00
bunnei
1d7de0a8ee
Merge pull request #4394 from lioncash/unused6 
video_core: Remove unused variables
 2020-07-23 19:54:59 -07:00
Rodrigo Locatti
7278c59d70
Merge pull request #4359 from ReinUsesLisp/clamp-shared 
renderer_{opengl,vulkan}: Clamp shared memory to host's limit
 2020-07-21 04:51:05 -03:00
Rodrigo Locatti
721e6015a8
Merge pull request #4360 from ReinUsesLisp/glasm-bar 
gl_arb_decompiler: Execute BAR even when inside control flow
 2020-07-21 04:50:55 -03:00
Rodrigo Locatti
9ea9a60e17
Merge pull request #4361 from ReinUsesLisp/lane-id 
decode/other: Implement S2R.LaneId
 2020-07-21 04:50:45 -03:00
Lioncash
82b7e5c8ee surface_params: Make use of designated initializers where applicable 
Provides a convenient way to avoid unnecessary zero initializing.
 2020-07-21 02:27:22 -04:00
Lioncash
bd9545a3a8 surface_params: Remove redundant assignment 
This is a redundant assignment that can be removed.
 2020-07-21 02:26:49 -04:00
Lioncash
c705a1db96 surface_params: Replace questionable usages of the comma operator with semicolons 
These are bugs waiting to happen.
 2020-07-21 02:26:48 -04:00
Lioncash
e17fb5ee97 video_core: Remove unused variables 
Silences several compiler warnings about unused variables.
 2020-07-21 00:57:25 -04:00
Lioncash
4b369126c4 vk_rasterizer: Remove unused variable in Clear() 
The relevant values are already assigned further down in the lambda, so
this can be removed entirely.
 2020-07-21 00:49:10 -04:00
Lioncash
059305a6bf compatible_formats: Add missing header guard 
Prevents potential inclusion issues from occurring.
 2020-07-21 00:42:19 -04:00
Lioncash
6adc824d9d video_core: Allow copy elision to take place where applicable 
Removes const from some variables that are returned from functions, as
this allows the move assignment/constructors to execute for them.
 2020-07-21 00:36:13 -04:00
bunnei
3d13d7f48f
Merge pull request #4324 from ReinUsesLisp/formats 
video_core: Fix, add and rename pixel formats
 2020-07-21 00:13:04 -04:00
David Marcec
dd4a02d15c video_core: Remove redundant pixel format type 
We already get the format type before converting shadow formats and during shadow formats.
 2020-07-21 12:44:32 +10:00
Lioncash
26c6c71837 buffer_cache: Eliminate redundant map lookup in MarkRegionAsWritten() 
We can make use of emplace()'s return value to determine whether or not
we need to perform an increment.

emplace() performs no insertion if an element already exist, so this can
eliminate a find() call.
 2020-07-20 17:48:00 -04:00
ReinUsesLisp
a8a2526128 gl_arb_decompiler: Use NV_shader_buffer_{load,store} on assembly shaders 
NV_shader_buffer_{load,store} is a 2010 extension that allows GL applications
to use what in Vulkan is known as physical pointers, this is basically C
pointers. On GLASM these is exposed through the LOAD/STORE/ATOM
instructions.

Up until now, assembly shaders were using NV_shader_storage_buffer_object.
These work fine, but have a (probably unintended) limitation that forces
us to have the limit of a single stage for all shader stages. In contrast,
with NV_shader_buffer_{load,store} we can pass GPU addresses to the
shader through local parameters (GLASM equivalent uniform constants, or
push constants on Vulkan). Local parameters have the advantage of being
per stage, allowing us to generate code without worrying about binding
overlaps.
 2020-07-18 01:59:57 -03:00
bunnei
90cbcaa44a
Merge pull request #4273 from ogniK5377/async-shaders-prod 
video_core: Add asynchronous shader decompilation and compilation
 2020-07-18 00:48:27 -04:00
David Marcec
967307d3be Fix style issues 2020-07-18 14:24:32 +10:00
bunnei
821d295f24
Merge pull request #4364 from lioncash/desig5 
vulkan: Make use of designated initializers where applicable
 2020-07-18 00:12:43 -04:00
ReinUsesLisp
81c8f92f2e vk_device: Fix build error on old MSVC versions 
Designated initializers on old MSVC versions fail to build when they
take the address of a constant.
 2020-07-17 20:27:53 -03:00
bunnei
19c6bf72db
Merge pull request #4322 from ReinUsesLisp/fix-dynstate 
vk_state_tracker: Fix dirty flags for stencil_enable on VK_EXT_extended_dynamic_state
 2020-07-17 09:50:45 -04:00
LC
47956a3bbc
Merge pull request #4369 from lioncash/hle-macro 
macro_hle: Remove unnecessary std::make_pair calls
 2020-07-17 05:20:41 -04:00
LC
9d3cbf6a90
Merge pull request #4340 from lioncash/remove 
shader_cache: Make use of std::erase_if
 2020-07-17 05:19:20 -04:00
David Marcec
85b591f6f0 Remove duplicate config 2020-07-17 14:26:18 +10:00
David Marcec
f48187449e Use conditional var 2020-07-17 14:26:17 +10:00
David Marcec
2ba195aa0d Drop max workers from 8->2 for testing 2020-07-17 14:26:15 +10:00
David Marcec
85d7a8f466 Rebase for per game settings 2020-07-17 14:26:14 +10:00
David Marcec
468bd9c1b0 async shaders 2020-07-17 14:24:57 +10:00
Lioncash
c0650cd82c macro_hle: Remove unnecessary static keywords 
These functions are already in an anonymous namespace which makes the
functions internally linked.
 2020-07-16 23:17:17 -04:00
David
9cca0c2f83
Merge pull request #4368 from lioncash/macro 
macro: Resolve missing parameter in doxygen comment
 2020-07-17 13:13:22 +10:00
David
3ce4edba64
Merge pull request #4370 from lioncash/simplify 
macro_hle: Simplify shift expression in HLE_771BB18C62444DA0()
 2020-07-17 13:13:05 +10:00
Lioncash
be6b7591d9 macro_hle: Simplify shift expression in HLE_771BB18C62444DA0() 
Given the expression involves a 32-bit value, this simplifies down to
just: 0x3ffffff. This is likely a remnant from testing that was never
cleaned up.

Resolves a -Wshift-overflow warning.
 2020-07-16 22:16:11 -04:00
Lioncash
cc935d997b macro_hle: Remove unnecessary std::make_pair calls 
The purpose of make_pair is generally to deduce the types within the
pair without explicitly specifying the types, so these usages were
generally unnecessary, particularly when the type is enforced by the
array declaration.
 2020-07-16 21:59:25 -04:00
Lioncash
502dbfb9eb macro: Resolve missing parameter in doxygen comment 
Resolves a -Wdocumentation warning.
 2020-07-16 21:54:42 -04:00
Lioncash
7785123b1c wrapper: Make use of designated initializers where applicable 2020-07-16 20:01:01 -04:00
Lioncash
01da386617 vk_texture_cache: Make use of designated initializers where applicable 2020-07-16 19:52:38 -04:00
Lioncash
169759e069 vk_texture_cache: Amend mismatched access masks and indices in UploadBuffer 
Discovered while converting relevant parts of the codebase over to
designated initializers.
 2020-07-16 19:45:46 -04:00
Lioncash
08d36afd40 vk_swapchain: Make use of designated initializers where applicable 2020-07-16 19:27:02 -04:00
Lioncash
3c060503bc vk_stream_buffer: Make use of designated initializers where applicable 2020-07-16 19:22:11 -04:00
Lioncash
70147e913f vk_staging_buffer_pool: Make use of designated initializers where applicable 2020-07-16 19:22:03 -04:00
Lioncash
2025f847bb vk_shader_util: Make use of designated initializers where applicable 2020-07-16 19:17:41 -04:00
Lioncash
97e7663004 vk_scheduler: Make use of designated initializers where applicable 2020-07-16 19:11:43 -04:00
Lioncash
fd7af52ec3 vk_sampler_cache: Make use of designated initializers where applicable 2020-07-16 19:06:40 -04:00
Lioncash
772b6e4d28 vk_resource_manager: Make use of designated initializers where applicable 2020-07-16 19:02:35 -04:00
Lioncash
8ebd6a21c5 vk_renderpass_cache: Make use of designated initializers where applicable 2020-07-16 18:57:23 -04:00
Lioncash
01f297f2e0 vk_rasterizer: Make use of designated initializers where applicable 2020-07-16 18:49:42 -04:00
Lioncash
c07b0ffe47 vk_query_cache: Make use of designated initializers where applicable 2020-07-16 18:34:04 -04:00
Lioncash
d43e923990 vk_pipeline_cache: Make use of designated initializers where applicable 2020-07-16 18:32:29 -04:00
Lioncash
7d5f93832c vk_memory_manager: Make use of designated initializers where applicable 2020-07-16 18:26:30 -04:00
Lioncash
75c00c3cb0 vk_image: Make use of designated initializers where applicable 2020-07-16 18:24:26 -04:00
Lioncash
6d165481ad vk_descriptor_pool: Make use of designated initializers where applicable 2020-07-16 18:19:45 -04:00
Lioncash
fb563e75e9 vk_graphics_pipeline: Resolve narrowing warnings 
For whatever reason, VK_TRUE and VK_FALSE aren't defined as having a
VkBool32 type, so we need to cast to it explicitly.
 2020-07-16 18:13:49 -04:00
Lioncash
5330ca396d vk_compute_pipeline: Make use of designated initializers where applicable 2020-07-16 17:32:12 -04:00
Lioncash
757ddd8158 vk_compute_pass: Make use of designated initializers where applicable 
Note: Some barriers can't be converted over yet, as they ICE MSVC.
 2020-07-16 17:23:56 -04:00
Lioncash
a66a0a6a53 vk_buffer_cache: Make use of designated initializers where applicable 
Note: An array within CopyFrom() cannot be converted over yet, as it
ICEs MSVC when converted over.
 2020-07-16 16:59:39 -04:00
Rodrigo Locatti
be68ee88c2
Merge pull request #4333 from lioncash/desig3 
vk_graphics_pipeline: Make use of designated initializers where applicable
 2020-07-16 17:41:45 -03:00
Rodrigo Locatti
b6d73ec9c2
Merge pull request #4332 from lioncash/vkdev 
vk_device: Make use of designated initializers where applicable
 2020-07-16 17:41:20 -03:00
ReinUsesLisp
210cc0204d decode/other: Implement S2R.LaneId 
This maps to host's thread id.

- Fixes graphical issues on Paper Mario.
 2020-07-16 16:09:39 -03:00
ReinUsesLisp
88e57b13e0 gl_arb_decompiler: Execute BAR even when inside control flow 
Unlike GLSL, GLASM allows us to call BAR inside control flow.

- Fixes graphical artifacts in Paper Mario.
 2020-07-16 16:05:52 -03:00
ReinUsesLisp
a5a72cbd20 renderer_{opengl,vulkan}: Clamp shared memory to host's limit 
This stops shaders from failing to build when the exceed host's shared
memory size limit. An error is logged.
 2020-07-16 16:02:46 -03:00
bunnei
98b36625fa
Merge pull request #4321 from lioncash/desig 
vk_blit_screen: Make use of designated initializers where applicable
 2020-07-16 14:55:36 -04:00
Lioncash
969100d41a shader_cache: Make use of std::erase_if 
Now that we use C++20, we can also make use of std::erase_if instead of
needing to do the erase-remove idiom.
 2020-07-14 15:49:15 -04:00
bunnei
666b37ad56
Merge pull request #4242 from ReinUsesLisp/maxwell-dma 
maxwell_dma: Match official doc and support pitch->voxel copies
 2020-07-14 14:04:16 -04:00
Lioncash
0f8b977663 vk_device: Make use of designated initializers where applicable 
Avoids redundant repetitions of variable names, and allows assignment
all in one statement.
 2020-07-13 22:24:01 -04:00
Lioncash
0475a167f8 vk_graphics_pipeline: Make use of designated initializers where applicable 
Avoids redundant variable name repetitions.
 2020-07-13 21:07:56 -04:00
ReinUsesLisp
fbc232426d video_core: Rearrange pixel format names 
Normalizes pixel format names to match Vulkan names. Previous to this
commit pixel formats had no convention, leading to confusion and
potential bugs.
 2020-07-13 01:44:23 -03:00
ReinUsesLisp
eda37ff26b video_core: Fix DXT4 and RGB565 2020-07-13 01:01:09 -03:00
ReinUsesLisp
a8dab2ffb3 video_core/format_lookup_table: Add formats with existing PixelFormat 2020-07-13 01:01:09 -03:00
ReinUsesLisp
480850ffe7 video_core: Fix B5G6R5_UNORM render target format 2020-07-13 01:01:09 -03:00
ReinUsesLisp
990b14f181 video_core: Fix B5G6R5U 2020-07-13 01:01:09 -03:00
ReinUsesLisp
1d20aac795 video_core: Implement RGBA32_SINT render target 2020-07-13 01:01:09 -03:00
ReinUsesLisp
9338599d72 video_core: Implement RGBA32_SINT render target 2020-07-13 01:01:09 -03:00
ReinUsesLisp
95c0f5afe5 video_core: Implement RGBA16_SINT render target 2020-07-13 01:01:09 -03:00
ReinUsesLisp
977d6c46f3 video_core: Implement RGBA8_SINT render target 2020-07-13 01:01:09 -03:00
ReinUsesLisp
50c6030a8d video_core: Implement RG32_SINT render target 2020-07-13 01:01:09 -03:00
ReinUsesLisp
e849d68048 video_core: Implement RG8_SINT render target and fix RG8_UINT 2020-07-13 01:01:09 -03:00